Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vagrant: use LDFLAGS="-Wl,--no-as-needed" in sanitizer runs #255

Merged
merged 5 commits into from
May 15, 2020
Merged

vagrant: use LDFLAGS="-Wl,--no-as-needed" in sanitizer runs #255

merged 5 commits into from
May 15, 2020

Commits on May 15, 2020

  1. Revert "hotfix: vagrant: temporarily disable TEST-46-HOMED w/ sanitiz… 

    …ers"

This reverts commit 800b173.
    @mrc0mmand
    mrc0mmand committed May 15, 2020
    Configuration menu
    Copy the full SHA
    51a17d5 View commit details
    Browse the repository at this point in the history

  2. Revert "jenkins: switch the cron job to clang w/ sanitizers" 

    This reverts commit f86c6ce.
    @mrc0mmand
    mrc0mmand committed May 15, 2020
    Configuration menu
    Copy the full SHA
    45538a3 View commit details
    Browse the repository at this point in the history

  3. Revert "vagrant: skip TEST-46-HOMED in the clang job w/ sanitizers" 

    This reverts commit 8ff742b.
    @mrc0mmand
    mrc0mmand committed May 15, 2020
    Configuration menu
    Copy the full SHA
    bbae0d0 View commit details
    Browse the repository at this point in the history

  4. Revert "jenkins: switch the sanitizer run to gcc (temporarily)" 

    This reverts commit dfe84a2.
    @mrc0mmand
    mrc0mmand committed May 15, 2020
    Configuration menu
    Copy the full SHA
    4097895 View commit details
    Browse the repository at this point in the history

  5. vagrant: use LDFLAGS="-Wl,--no-as-needed" in sanitizer runs 

    Since version 10, both gcc and clang started to ignore certain linker errors
when compiling with -fsanitize=address. This eventually leads up to -lcrypt
not being correctly propagated, but the fact is masked by the aforementioned
issue. However, when the binary attempts to load a symbol from the libcrypt
binary, it crashes since it's not linked correctly against it.
Negating the -Wl,--as-needed used by default by -Wl,--no-as-needed seems to
help in this case.

See:
  https://bugzilla.redhat.com/show_bug.cgi?id=1827338#c3
  systemd#247
    @mrc0mmand
    mrc0mmand committed May 15, 2020
    Configuration menu
    Copy the full SHA
    18b7044 View commit details
    Browse the repository at this point in the history