Use separate Github environment for releasing pytest-taskgraph #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eijebong
approved these changes
Dec 12, 2024
| 4. Wait for the ``pypi-publish`` Github workflow and ``push-image-decision`` task to finish. | ||
| 3. Draft a release in Github pointing to the above commit. | ||
|
|
||
| a. Create a new tag of the form ``pytest-taskgraph-vX.Y.Z`` |
There was a problem hiding this comment.
Bit weird to have vX.Y.Z on this tag but not on the other. Don't have a very strong opinion on this though
There was a problem hiding this comment.
Yeah... I kind of wish we had used vX.Y.Z for the other one, it would make some Taskgraph logic easier and seems to be more of a standard. I don't mind dropping the v here though, also not a super strong opinion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just ensures we don't accidentally publish the wrong package on the wrong release. The pypi-publish action should do this already, but doesn't hurt to have an extra safeguard.