👾 Add proof of concept leak test 👾 #1368
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know this has been a longish time coming but here it is.
Ideally this will run in the same way that we run integration tests, based on the git diff.
This perf test is inline with all of my perf testing in that I have essentially codified the process here.
https://github.com/samccone/leaky provides us with the instrumentation layer so we do not have to worry about it and get to reuse all of our selenium work in our integration suite 💃 .
I currently have this hard coded to test against react, just to get some feedback on what everyone is thinking.
⛲ React:
node leak ^ as expected via #1332 (comment)
⛲ Vue
node leak ^ as expected via #1354
⛲ Angularjs
node leak ^ as expected via #1335
⛲ Knockoutjs
node and listener leak ^ as expected via #1334
⛲ Ember
node leak ^ as expected via #1333
^ is by no means a comprehensive run of all of the implementations just the ones I have run