Update URDF parser to use Tesseract XML namespace #1081
+1,107
−744
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #1059 by removing the URDF tag
tesseract_version
and moving the custom geometry implementations to atesseract
XML namespace. This should allow us to make further Tesseract-specific URDF additions in a clearer manner. Users will need to specify this XML namespace as follows:I think the URL is somewhat arbitrary, but should generally point to a location that gives the user more information about what elements are available in this namespace.
This PR also removes the behavior in
tesseract_version
< 2 of automatically converting collision mesh files into into convex hulls. Now, if users wanttesseract
to automatically convert mesh files to convex hulls, they will need to use the<tesseract:convex_mesh file="" convert="true"/>
element instead of just themesh
element.