Test argument really is a string before doing a filter_var. (webmozar…

…ts#135)
tomaszhanc · Oct 15, 2019 · 8c707ac · 8c707ac
1 parent a3a574a
commit 8c707ac
Show file tree

Hide file tree

Showing 6 changed files with 76 additions and 0 deletions.
diff --git a/src/Assert.php b/src/Assert.php
@@ -683,13 +683,16 @@ public static function false($value, $message = '')
     }
 
     /**
+     * @psalm-assert string $value
+     *
      * @param mixed  $value
      * @param string $message
      *
      * @throws InvalidArgumentException
      */
     public static function ip($value, $message = '')
     {
+        static::string($value, $message);
         if (false === \filter_var($value, \FILTER_VALIDATE_IP)) {
             static::reportInvalidArgument(\sprintf(
                 $message ?: 'Expected a value to be an IP. Got: %s',
@@ -699,13 +702,16 @@ public static function ip($value, $message = '')
     }
 
     /**
+     * @psalm-assert string $value
+     *
      * @param mixed  $value
      * @param string $message
      *
      * @throws InvalidArgumentException
      */
     public static function ipv4($value, $message = '')
     {
+        static::string($value, $message);
         if (false === \filter_var($value, \FILTER_VALIDATE_IP, \FILTER_FLAG_IPV4)) {
             static::reportInvalidArgument(\sprintf(
                 $message ?: 'Expected a value to be an IPv4. Got: %s',
@@ -715,13 +721,16 @@ public static function ipv4($value, $message = '')
     }
 
     /**
+     * @psalm-assert string $value
+     *
      * @param mixed  $value
      * @param string $message
      *
      * @throws InvalidArgumentException
      */
     public static function ipv6($value, $message = '')
     {
+        static::string($value, $message);
         if (false === \filter_var($value, \FILTER_VALIDATE_IP, \FILTER_FLAG_IPV6)) {
             static::reportInvalidArgument(\sprintf(
                 $message ?: 'Expected a value to be an IPv6. Got %s',
@@ -731,13 +740,16 @@ public static function ipv6($value, $message = '')
     }
 
     /**
+     * @psalm-assert string $value
+     *
      * @param mixed  $value
      * @param string $message
      *
      * @throws InvalidArgumentException
      */
     public static function email($value, $message = '')
     {
+        static::string($value, $message);
         if (false === \filter_var($value, FILTER_VALIDATE_EMAIL)) {
             static::reportInvalidArgument(\sprintf(
                 $message ?: 'Expected a value to be a valid e-mail address. Got %s',

diff --git a/tests/AssertTest.php b/tests/AssertTest.php
@@ -443,6 +443,7 @@ public function getTests()
             array('throws', array(function() { trigger_error('test'); }, 'Unthrowable'), false, false, 70000),
             array('throws', array(function() { throw new Error(); }, 'Throwable'), true, true, 70000),
             array('ip', array('192.168.0.1'), true),
+            array('ip', array(new ToStringClass('192.168.0.1')), false),
             array('ip', array('255.255.255.255'), true),
             array('ip', array('0.0.0.0'), true),
             array('ip', array('2001:0db8:0000:0042:0000:8a2e:0370:7334'), true),
@@ -455,6 +456,7 @@ public function getTests()
             array('ip', array(null), false),
             array('ip', array(false), false),
             array('ipv4', array('192.168.0.1'), true),
+            array('ipv4', array(new ToStringClass('192.168.0.1')), false),
             array('ipv4', array('255.255.255.255'), true),
             array('ipv4', array('0.0.0.0'), true),
             array('ipv4', array('2001:0db8:0000:0042:0000:8a2e:0370:7334'), false),
@@ -470,6 +472,7 @@ public function getTests()
             array('ipv6', array('255.255.255.255'), false),
             array('ipv6', array('0.0.0.0'), false),
             array('ipv6', array('2001:0db8:0000:0042:0000:8a2e:0370:7334'), true),
+            array('ipv6', array(new ToStringClass('2001:0db8:0000:0042:0000:8a2e:0370:7334')), false),
             array('ipv6', array('::ffff:192.0.2.1'), true),
             array('ipv6', array('::1'), true),
             array('ipv6', array('::'), true),
@@ -482,6 +485,7 @@ public function getTests()
             array('email', array(123), false),
             array('email', array('foo.com'), false),
             array('email', array('[email protected]'), true),
+            array('email', array(new ToStringClass('[email protected]')), false),
             array('uniqueValues', array(array('qwerty', 'qwerty')), false),
             array('uniqueValues', array(array('asdfg', 'qwerty')), true),
             array('uniqueValues', array(array(123, '123')), false),

diff --git a/tests/static-analysis/assert-email.php b/tests/static-analysis/assert-email.php
@@ -0,0 +1,15 @@
+<?php
+
+namespace Webmozart\Assert\Tests\StaticAnalysis;
+
+use Webmozart\Assert\Assert;
+
+/**
+ * @psalm-param mixed $value
+ */
+function consume($value): string
+{
+    Assert::email($value);
+
+    return $value;
+}
diff --git a/tests/static-analysis/assert-ip.php b/tests/static-analysis/assert-ip.php
@@ -0,0 +1,15 @@
+<?php
+
+namespace Webmozart\Assert\Tests\StaticAnalysis;
+
+use Webmozart\Assert\Assert;
+
+/**
+ * @psalm-param mixed $value
+ */
+function consume($value): string
+{
+    Assert::ip($value);
+
+    return $value;
+}
diff --git a/tests/static-analysis/assert-ipv4.php b/tests/static-analysis/assert-ipv4.php
@@ -0,0 +1,15 @@
+<?php
+
+namespace Webmozart\Assert\Tests\StaticAnalysis;
+
+use Webmozart\Assert\Assert;
+
+/**
+ * @psalm-param mixed $value
+ */
+function consume($value): string
+{
+    Assert::ipv4($value);
+
+    return $value;
+}
diff --git a/tests/static-analysis/assert-ipv6.php b/tests/static-analysis/assert-ipv6.php
@@ -0,0 +1,15 @@
+<?php
+
+namespace Webmozart\Assert\Tests\StaticAnalysis;
+
+use Webmozart\Assert\Assert;
+
+/**
+ * @psalm-param mixed $value
+ */
+function consume($value): string
+{
+    Assert::ipv6($value);
+
+    return $value;
+}