Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130771 / 25.04 / Add RedactedFileMetric and use to redact iSCSI CHAP secrets #211

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

bmeagherix
Copy link
Contributor

Add RedactedFileMetric and use redact_chap_passwords callback to redact iSCSI CHAP secrets.

This will replace the secrets in the copy of /etc/scst.conf.

@bugclerk bugclerk changed the title Add RedactedFileMetric and use to redact iSCSI CHAP secrets NAS-130771 / 25.04 / Add RedactedFileMetric and use to redact iSCSI CHAP secrets Aug 22, 2024
@bugclerk
Copy link

@truenas truenas deleted a comment from bugclerk Aug 22, 2024
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.83%. Comparing base (fe4fd3a) to head (98828e4).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
+ Coverage   91.65%   91.83%   +0.17%     
==========================================
  Files         102      103       +1     
  Lines        2265     2314      +49     
==========================================
+ Hits         2076     2125      +49     
  Misses        189      189              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmeagherix bmeagherix requested a review from a team August 22, 2024 18:56
@bmeagherix bmeagherix merged commit f104b53 into master Aug 22, 2024
6 checks passed
@bmeagherix bmeagherix deleted the redact_iscsi_chap_secret branch August 22, 2024 19:18
@bugclerk
Copy link

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants