Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132555 / 25.04 / Include snmp in plugins diagnostic. #244

Merged
merged 1 commit into from
Nov 16, 2024
Merged

Conversation

mgrimesix
Copy link
Contributor

SNMP is missing from the diagnostic.
This PR adds SNMP configuration and associated files to a diagnostic.

@mgrimesix mgrimesix requested review from anodos325 and a team November 15, 2024 21:02
@bugclerk bugclerk changed the title Include snmp in plugins diagnostic. NAS-132555 / 25.04 / Include snmp in plugins diagnostic. Nov 15, 2024
@bugclerk
Copy link

1 similar comment
@bugclerk
Copy link

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.12%. Comparing base (06479c8) to head (aa6d7b6).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
+ Coverage   91.09%   91.12%   +0.03%     
==========================================
  Files         103      104       +1     
  Lines        2348     2356       +8     
==========================================
+ Hits         2139     2147       +8     
  Misses        209      209              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bmeagherix bmeagherix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a backport to 24.10.1 ?

@mgrimesix mgrimesix merged commit c2b318f into master Nov 16, 2024
6 checks passed
@mgrimesix mgrimesix deleted the add-snmp branch November 16, 2024 03:10
@bugclerk
Copy link

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants