Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README: Replace API Key with Auth Token and Reflect Changes in… #72

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

sbrij001
Copy link
Contributor

@sbrij001 sbrij001 commented Sep 9, 2024

… YAML File

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • [ x] I acknowledge that all my contributions will be made under the project's license.

@sbrij001
Copy link
Contributor Author

sbrij001 commented Sep 9, 2024

@bnb Will you review this PR?

Copy link
Contributor

@bnb bnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some notes

README.md Outdated
Comment on lines 35 to 36
fromPhoneNumber: ${{ secrets.FROM_PHONE_NUMBER }} # alternatively, use a Repository Secret
toPhoneNumber: ${{ secrets.TO_PHONE_NUMBER }} # alternatively, use a Repository Secret
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comments from the original line don't make sense anymore since that's what we're doing

README.md Show resolved Hide resolved
@bnb bnb mentioned this pull request Oct 23, 2024
1 task
@bnb
Copy link
Contributor

bnb commented Oct 23, 2024

Should also be merged with #73

@ayyrickay
Copy link
Contributor

@sbrij001 merging these in to close this out

@ayyrickay ayyrickay merged commit e0a9d02 into main Nov 14, 2024
1 check passed
@ayyrickay ayyrickay deleted the sbrij001-patch-1 branch November 14, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants