Update action.yml with Auth Token #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed api key and api token and replaced with auth token
|
@bnb Can you review this PR? |
bnb
reviewed
Sep 12, 2024
Comment on lines
-5
to
+8
| fromPhoneNumber: | ||
| FROM_PHONE_NUMBER: | ||
| description: 'Phone number in your Twilio account to send the SMS from' | ||
| required: true | ||
| toPhoneNumber: | ||
| TO_PHONE_NUMBER: |
There was a problem hiding this comment.
you should check the README PR since I think it refers to fromPhoneNumber and toPhoneNumber.
action.yml
Outdated
Comment on lines
17
to
18
| TWILIO_AUTH_TOKEN: | ||
| description: 'A Twilio Auth Token. Can alternatively be stored in environment' |
There was a problem hiding this comment.
We should remove Can alternatively be stored in environment from all of these because it's... obvious/how it works.
|
Should also be merged with #72 |
bnb
approved these changes
Oct 23, 2024
|
@sbrij001 It looks like this can now be merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed api key and api token and replaced with auth token
Contributing to Twilio