Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update action.yml with Auth Token #73

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Update action.yml with Auth Token #73

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ff7950
Update action.yml with Auth Token
sbrij001 Sep 9, 2024
7aead76
remove env variable guidance
sbrij001 Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ name: 'Twilio SMS'
author: 'Twilio Labs'
description: 'Send an SMS from GitHub Actions using Twilio Programmable SMS'
inputs:
fromPhoneNumber:
FROM_PHONE_NUMBER:
description: 'Phone number in your Twilio account to send the SMS from'
required: true
toPhoneNumber:
TO_PHONE_NUMBER:
Comment on lines -5 to +8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should check the README PR since I think it refers to fromPhoneNumber and toPhoneNumber.

description: 'Phone number to send the SMS to'
required: true
message:
Expand All @@ -14,11 +14,8 @@ inputs:
TWILIO_ACCOUNT_SID:
description: 'A Twilio Account SID. Can alternatively be stored in environment'
required: true
TWILIO_API_KEY:
description: 'A Twilio API Key. Can alternatively be stored in environment'
required: true
TWILIO_API_SECRET:
description: 'A Twilio API Secret. Can alternatively be stored in environment'
TWILIO_AUTH_TOKEN:
description: 'A Twilio Auth Token. Can alternatively be stored in environment'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove Can alternatively be stored in environment from all of these because it's... obvious/how it works.

required: true
outputs:
messageSid:
Expand Down
Loading