-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates related to component land model (Combined PR#2107) #1845
Conversation
…eather-model into feature/noahmp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uturuncoglu Good work.
@uturuncoglu can you check noah-mp hash? I think correct one is NOAA-EMC/noahmp@0cd3e23 |
@DeniseWorthen I think there's still some conversations that are unresolved. Could you review those as well? |
1d8d088
looks ok
|
orion and hercules ran ok as well |
@jkbk2004 I am getting permission error because the permission is not correct for that folder. See following output,
As you can see |
@jkbk2004 This is also same for |
fixed
|
@jkbk2004 Thanks. I am also getting error from following folders,
If you don't mind could you also fix those. Thanks again for your help. |
all good now: I checked on other machines as well.
|
@jkbk2004 Thanks again. |
@uturuncoglu Sure! Thanks a lot for doing this heavy lifting PR! |
Blocked By
Requires ESMF 8.5.0 install on RDHPCS/WCOSS2
Description
This PR aims to update component version of the land model to bring fully coupled atmosphere-land coupling capability to UFS Weather Model. The new development also allows to use different resolutions in atmosphere and land components C96 atmosphere and C384 land. The fully coupled configuration is only tested with global application at this point and requires additional work to make it work with regional applications like HAFS.
The initial evolution of the fully coupled atmosphere-land configuration can be found in the following presentation that was given in Noah-MP Workshop & Tutorial.
https://docs.google.com/presentation/d/1VFZwNisxwXUkeGW0iSrVJj8W0YaPTfllFVhbF42MMOE/edit#slide=id.g223ef07cc4d_0_0
The details about the content of the PR can be seen as following;
The FMS dependency is removed from NOAHMP-Interface and NOAHMP component model along with switching ESMF multi-tile I/O support (requires using ESMF >=8.5.0)
Following new RTs are introduced,
control_p8_atmlnd
: fully coupled ATM-LND configurationcontrol_restart_p8_atmlnd
: tests restart capability of fully coupled ATM-LND configurationdatm_cdeps_lnd_era5
: component land model forced with ERA5datm_cdeps_lnd_era5_rst
: tests restart capability of component land model forced with ERA5Following RT is removed,
datm_cdeps_lnd_gswp3_rst
: This is replaced withdatm_cdeps_lnd_era5_rst
Commit Message
Input data additions/changes
The new input data folders can be found in following directories:
Cheyenne
/glade/work/turuncu/RT/NEMSfv3gfs/input-data-20221101/NOAHMP_IC/
/glade/work/turuncu/RT/NEMSfv3gfs/input-data-20221101/DATM_ERA5_input_data_v2/
Orion/Hercules
/work/noaa/nems/tufuk/RT/NEMSfv3gfs/input-data-20221101/NOAHMP_IC
/work/noaa/nems/tufuk/RT/NEMSfv3gfs/input-data-20221101/DATM_ERA5_input_data_v2
Anticipated changes to regression tests:
Subcomponents involved:
Library Updates/Changes
The ESMF library needs to be updated to its latest public release (8.5.0). This also requires updating PIO library to its recent version 2.5.10.
Combined with PR's (If Applicable): #2107
Commit Queue Checklist:
Linked PR's and Issues:
Depends on Update NoahMP model NOAA-EMC/noahmp#6
Depends on Updates for component land model NOAA-EMC/CMEPS#98
Depends on Update CDEPS NOAA-EMC/CDEPS#58
Depends on Updates for component land model NOAA-EMC/fv3atm#682
Depends on Updates for component land model ccpp-physics#94
Closes ESMF requirement for external land component #1542
Closes baseline directory does not exist on Cheyenne #1843
Closes Enable fully coupled atmosphere-land configuration with component version of NoahMP land model #2045
Combined PR:
Testing Day Checklist:
Testing Log (for CM's):
Need help to run opnReqTest for atmosphere-land coupled configuration. The RT that tests restart capability for atmosphere-land was passing with ESMF 8.5.0b17.
The code is first tested with existing ESMF version (8.3.0b09) to check the modification related with the component land is not affecting existing applications. All the tests are passed on Orion (with Intel) except land related RTs which requires newer version of the ESMF library. The 8.3.0b09 is not tested on Cheyenne since the beeline was missing.
The code will be tested against ESMF 8.5.0 once it is available on Orion and Cheyenne to identify possible answer changes due to the version changes since there is no any answer change with ESMF 8.3.0b09.