Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/1463 Pandas 2.2.0 FutureWarning resolution by using assignment instead of … #1464

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

derinwalters
Copy link
Contributor

From #1463

Minor update to replace inplace fillna of default values with an assignment, as per FutureWarning from Pandas 2.2.0.

Please note I encountered the two issues below that existed on the master branch prior to any edits. Otherwise, all is clean.

  1. "pre-commit run --all" has one mypy typing error that looks like it could be a real issue where a series is returned from category dtype check rather than bool.
pandera/engines/pandas_engine.py:1407: error: Incompatible return value type (got "Union[Series[Any], DataFrame]", expected "Union[bool, Iterable[bool]]")  [return-value]
pandera/engines/pandas_engine.py:1407: note: Error code "return-value" not covered by "type: ignore" comment
  1. pytest has one fail related to Pandas grouping that I didn't fully understand the cause of.
FAILED tests/core/test_checks.py::test_check_groups - pandera.errors.SchemaError: Error while executing check function: KeyError("foo")

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4df61da) 94.29% compared to head (a252248) 94.29%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1464   +/-   ##
=======================================
  Coverage   94.29%   94.29%           
=======================================
  Files          91       91           
  Lines        7024     7024           
=======================================
  Hits         6623     6623           
  Misses        401      401           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@derinwalters
Copy link
Contributor Author

@cosmicBboy Do you have any knowledge of the two issues with master branch that I mentioned above? Looks like all pull requests from the past three weeks are running into the same linter issue at least.

@cosmicBboy
Copy link
Collaborator

@derinwalters lemme check

@cosmicBboy
Copy link
Collaborator

@derinwalters do you mind rebasing on main? Just merged #1468

@derinwalters
Copy link
Contributor Author

@cosmicBboy green means go. Thanks for the assist!

Copy link
Collaborator

@cosmicBboy cosmicBboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @derinwalters! 🚀

@cosmicBboy cosmicBboy merged commit 3c8c28b into unionai-oss:main Feb 19, 2024
56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants