Inspection refactoring and cleanup #400
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to avoid adding return variables for each value we want to extract at migration time we are now collecting them in a result object. This object could later be extended and reused for the inspect scripts instead of using a map.
When migrating from a non-containerized server, the user may want to setup confidential computing attestation.
cbosdo
force-pushed
the
inspect-refactoring
branch
from
bc75baa
to
dc76504
Compare
|
We have rather clean dir structure, how about having |
cbosdo
force-pushed
the
inspect-refactoring
branch
2 times, most recently
from
3432d88
to
9db69f8
Compare
I was hesitating doing it... looks like I'll do it if we have the same idea 😉 |
cbosdo
force-pushed
the
inspect-refactoring
branch
2 times, most recently
from
8d7bde6
to
4692c1d
Compare
Using podman creds is not secure as those will show up in the the ps output. Instead we generate a temporary podman authentication file and pass it to podman pull.
cbosdo
force-pushed
the
inspect-refactoring
branch
from
4692c1d
to
ab101b8
Compare
It doesn't make sense to try to extract all the values for both containers and hosts. This commit introduces Inspector objects that are responsible for generating the inspection script and parsing it into a structure. While at it, the extracted values that were not used have been removed. This gains quite some time at each execution since extracting the SCC registration status was quite long. While doing this we could also drop the InspectData proxyHost flag as SCC credentials are extracted for both server and proxy hosts.
cbosdo
force-pushed
the
inspect-refactoring
branch
from
ab101b8
to
03a0910
Compare
3 tasks
rjmateus
reviewed
Jul 18, 2024
| token := base64.StdEncoding.EncodeToString([]byte(fmt.Sprintf("%s:%s", creds.SccUsername, creds.SccPassword))) | ||
| authFileContent := fmt.Sprintf(`{ | ||
| "auths": { | ||
| "registry.suse.com" : { |
There was a problem hiding this comment.
Can we hard code this registry when we can have a different registry name on the cloud?
There was a problem hiding this comment.
This is only set if we have SCC credentials... so no other registry uses them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Split the inspection scripts based on their usage
It doesn't make sense to try to extract all the values for both
containers and hosts. This commit introduces Inspector objects that are
responsible for generating the inspection script and parsing it into a
structure.
While at it, the extracted values that were not used have been removed.
This gains quite some time at each execution since extracting the
SCC registration status was quite long.
While doing this we could also drop the InspectData proxyHost flag as
SCC credentials are extracted for both server and proxy hosts.
Test coverage
Unit tests were added
DONE
Links
Issue(s): #
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Before you merge
Check How to branch and merge properly!