Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inspection refactoring and cleanup #400

Closed
wants to merge 6 commits into from

Commits on Jul 11, 2024

  1. Use an object to collect the migration data

    In order to avoid adding return variables for each value we want to
    extract at migration time we are now collecting them in a result object.
    
    This object could later be extended and reused for the inspect scripts
    instead of using a map.
    cbosdo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    d8118ab View commit details
    Browse the repository at this point in the history
  2. Create coco attestation service files during migration

    When migrating from a non-containerized server, the user may want to
    setup confidential computing attestation.
    lucidd authored and cbosdo committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    30e0029 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Add testing utility functions

    cbosdo committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    041d2cd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7f6222e View commit details
    Browse the repository at this point in the history
  3. Remove the use of --creds in podman pull

    Using podman creds is not secure as those will show up in the the ps output.
    Instead we generate a temporary podman authentication file and pass it to
    podman pull.
    cbosdo committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    8d6aea5 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Split the inspection scripts based on their usage

    It doesn't make sense to try to extract all the values for both
    containers and hosts. This commit introduces Inspector objects that are
    responsible for generating the inspection script and parsing it into a
    structure.
    
    While at it, the extracted values that were not used have been removed.
    This gains quite some time at each execution since extracting the
    SCC registration status was quite long.
    
    While doing this we could also drop the InspectData proxyHost flag as
    SCC credentials are extracted for both server and proxy hosts.
    cbosdo committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    03a0910 View commit details
    Browse the repository at this point in the history