-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GFP equation #160
Comments
The usual formula used in MS analysis: which is equals to From Numpy documentation: It seems that MNE formula is missing the |
No that was from a generic method, not expecting any reference (could actually be applied to any channel type..) |
All good, it was already patch. Now 'gfp' is an alias for std for EEG sensors, and RMS for MEG sensors. |
We might also need to use RMS for MEG data in our computations |
Oh ! Good point |
As suggested in taits 2022 we could use RMS for GFP calculation as well as cosine instead of correlations The main issue ( and it is the same for #93 ) is the use of smoothing algorithm that we might need to check/adapt for this need metrics |
I added to #93 the part about RMS for 'extract-gfp-peaks', but it seems we do need 'ignore-polarity' to False for magnetometers |
As
I'm creating a new branch to keep things clearer. |
But are we actually enforcing centered data? I don't think average reference is a requirement at the moment, should it? |
Yes I agree, the current implementation enforce centered data, and so everything words well for EEG. However, when tait 2022 extend the definition of EEG microstates to MEG microstates, they propose to use RMS as a measure of global field power and cosine similarity as a measure on similarity. This measures extend the current methodology to reference free recordings such a MEG. In case of centered data, std = rms and cosine similarity == correlation , so the pipelines hold in |
Looking quickly through GFP stuff, this is the equation I find in MNE:
And this is in pycrostates:
pycrostates/pycrostates/preprocessing/extract_gfp_peaks.py
Line 160 in ff3da2b
@vferat Any opinion here?
The text was updated successfully, but these errors were encountered: