Add support for ERP analysis: ignore_polarity = False #93
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #160
As discussed in #92, we could add support for taking into account polarities in the analysis.
Here is a list of changes that need to be implemented:
self._ignore_polarity
(bool
) attribute to_BaseCluster
. This attribute can only be changed using theignore_polarity
argument of the.fit()
method ( to be added).By default during fitting,
ignore_polarity
should be set to True forRaw
,Epochs
,ChData
andFalse
forEvoked
..predict
should have the same behaviour as.fit()
: it should useself._ignore_polarity
.ignore_polarity
value used during prediction should be store in segmentations_BaseCluster.invert_polarity
should not work whenself._ignore_polarity
is set toFalse
.metrics
should take into accountcluster._ignore_polarity
.Feel free to complete this list