Credential plugins CI fixes #1098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
approved these changes
Apr 23, 2024
|
I've split out the AWS and SSH part into #1099, as that works… |
missing dependencies
evgeni
force-pushed
the
credentials-fixes
branch
from
3afe2b3
to
e6ecbe8
Compare
missing dependencies
while these are not required for tests to run, their absence still spams the logs with "Plugin is missing" errors, making it really hard to find actual issues
otherwise previous runs leave plugins installed which can influence test execution
no idea why it was pinned in the past, but pinning seems to miss-behave when we use purge_plugins=>true in tests and breaks idempotency tests
evgeni
force-pushed
the
credentials-fixes
branch
from
27684a4
to
423d3d2
Compare
bastelfreak
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
This Pull Request (PR) fixes the following issues