Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credential plugins CI fixes #1098

Merged
merged 5 commits into from
Apr 23, 2024
Merged

Credential plugins CI fixes #1098

merged 5 commits into from
Apr 23, 2024

Commits on Apr 23, 2024

  1. fix gitlab-plugin CI 

    missing dependencies
    @evgeni
    evgeni committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    08cb22b View commit details
    Browse the repository at this point in the history

  2. fix browserstack-integration CI 

    missing dependencies
    @evgeni
    evgeni committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    cb0ade5 View commit details
    Browse the repository at this point in the history

  3. also install optional dependencies 

    while these are not required for tests to run, their absence still spams
the logs with "Plugin is missing" errors, making it really hard to find
actual issues
    @evgeni
    evgeni committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    a82e268 View commit details
    Browse the repository at this point in the history

  4. set purge_plugins => true when testing different credential plugins 

    otherwise previous runs leave plugins installed which can influence test
execution
    @evgeni
    evgeni committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    0f96dc3 View commit details
    Browse the repository at this point in the history

  5. don't pin plain-credentials plugin 

    no idea why it was pinned in the past, but pinning seems to miss-behave
when we use purge_plugins=>true in tests and breaks idempotency tests
    @evgeni
    evgeni committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    423d3d2 View commit details
    Browse the repository at this point in the history