Another set of floating point optimisation attemps #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
commented
May 31, 2022
| template <typename T> | ||
| T isnan(T value) noexcept = delete; | ||
|
|
||
| inline bit_cast_constexpr bool isnan(float value) noexcept |
There was a problem hiding this comment.
The creation of this was motivated by making it constexpr. This could be the default in C++23: https://open-std.org/JTC1/SC22/WG21/docs/papers/2019/p0533r5.pdf
Codecov Report
@@ Coverage Diff @@
## master #828 +/- ##
=======================================
Coverage 99.27% 99.27%
=======================================
Files 88 88
Lines 13296 13296
=======================================
Hits 13200 13200
Misses 96 96
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.