Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testing: don't print the output of marimo unless there was an error #2836

Merged
merged 3 commits into from
Jul 5, 2024
Merged

testing: don't print the output of marimo unless there was an error #2836

merged 3 commits into from
Jul 5, 2024

Conversation

superlopuh
Copy link
Member

No description provided.

@superlopuh superlopuh added the testing PRs that modify tests label Jul 4, 2024
@superlopuh superlopuh self-assigned this Jul 4, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.83%. Comparing base (612c1b2) to head (5807fc2).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2836      +/-   ##
==========================================
- Coverage   89.83%   89.83%   -0.01%     
==========================================
  Files         397      397              
  Lines       49203    49203              
  Branches     7551     7551              
==========================================
- Hits        44202    44200       -2     
- Misses       3807     3808       +1     
- Partials     1194     1195       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superlopuh
Copy link
Member Author 

MLIR is installed, running tests.
/home/runner/work/xdsl/xdsl/llvm-project/build/bin//mlir-opt
Running docs/marimo/mlir/onnx_demo.py
All marimo mlir tests passed successfully.

Base automatically changed from sasha/tests/fix-mlir-opt-check to main July 4, 2024 10:26
webmiche
webmiche approved these changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@webmiche webmiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works on my machine. Just a minor comment 👍

Makefile
error_message=$$(python3 "$$file" 2>&1) || { \
echo "Error running $$file"; \
echo "$$error_message"; \
exit 1; \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make it s.t. it does not fail on the first failing one, but runs all of them and then reports the errors or something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2841

@superlopuh superlopuh merged commit 1826285 into main Jul 5, 2024
10 checks passed
@superlopuh superlopuh deleted the sasha/tests/marimo-quiet branch July 5, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmiche webmiche webmiche approved these changes

@compor compor Awaiting requested review from compor

@zero9178 zero9178 Awaiting requested review from zero9178

@AntonLydike AntonLydike Awaiting requested review from AntonLydike

@math-fehr math-fehr Awaiting requested review from math-fehr

@PapyChacal PapyChacal Awaiting requested review from PapyChacal

Assignees

@superlopuh superlopuh

Labels
testing PRs that modify tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@superlopuh @webmiche