Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: don't print the output of marimo unless there was an error #2836

Merged
merged 3 commits into from
Jul 5, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,11 @@ tests-toy: filecheck-toy pytest-toy
tests-marimo:
@for file in docs/marimo/*.py; do \
echo "Running $$file"; \
python3 "$$file" || exit 1; \
error_message=$$(python3 "$$file" 2>&1) || { \
echo "Error running $$file"; \
echo "$$error_message"; \
exit 1; \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make it s.t. it does not fail on the first failing one, but runs all of them and then reports the errors or something?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

}; \
done
@echo "All marimo tests passed successfully."

Expand All @@ -66,7 +70,11 @@ tests-marimo-mlir:
@echo "MLIR is installed, running tests."
@for file in docs/marimo/mlir/*.py; do \
echo "Running $$file"; \
python3 "$$file" || exit 1; \
error_message=$$(python3 "$$file" 2>&1) || { \
echo "Error running $$file"; \
echo "$$error_message"; \
exit 1; \
}; \
done
@echo "All marimo mlir tests passed successfully."

Expand Down
Loading