adding derivatives folder to the upload #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtyoung84
requested changes
Oct 14, 2024
jtyoung84
reviewed
Oct 14, 2024
| f"Uploading {derivatives_path} to {s3_derivatives_dir}" | ||
| ) | ||
| utils.sync_dir_to_s3(derivatives_path, s3_derivatives_dir) | ||
| logging.info(f"Removing: {derivatives_path}") |
There was a problem hiding this comment.
I don't think we want to remove the derivatives path here. You can probably just log that the upload finished if you want.
jtyoung84
reviewed
Oct 14, 2024
| derivatives_path = Path(self.job_settings.input_source).joinpath( | ||
| "derivatives" | ||
| ) | ||
| if self.job_settings.s3_location is not None: |
There was a problem hiding this comment.
Maybe add a quick check that the derivatives folder actually exists?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @jtyoung84,
I have included the derivatives folder to the upload. Please, let me know if you want me to include something else. I noticed that in the tests, the upload to S3 it is not directly being checked for any of the files.
I can work on this on and add it for the next PR.