[Codebase] Automatically find or add world #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It sounded like AI and had redundancy, I'm ashamed
|
@Dragorn421 could you look at this at some point? |
|
Would an exception or warning popup work better? |
Lilaa3
changed the title
Dragorn421
reviewed
Aug 19, 2024
Co-authored-by: Dragorn421 <[email protected]>
Dragorn421
added
the
merge soon
|
This will fix #330 |
Dragorn421
reviewed
Aug 19, 2024
fast64_internal/utility.py
Outdated
| return scene.world | ||
| if bpy.data.worlds: | ||
| world: World = bpy.data.worlds.values()[0] | ||
| print(f'No world selected in scene, selected the first one found in this file "{world.name}".') |
There was a problem hiding this comment.
actually I just realized this severely spams the console. Could you add a counter for this print and only print it the first 10 times or something
use a dirty global variable :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible solution to #330
Never changes the actual scene.world, as that should be left to the user, the important logic is in create_or_get_world.
This will almost never create a world because of the f3d nodes library having its own world