-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metric Spaces are Normal #1002
Metric Spaces are Normal #1002
Conversation
- move instance of Coq reals to normedtype.v - fix changelog - linting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed we can use an instance of realType
to remove the R : realType
parameter from the statement of normal_spaceP
but this requires to move a section from Rstruct.v
to avoid a circularity when loading files. Is it acceptable?
Looks great, exactly what I was hoping for. It also explains why searching for instances failed. There's probably a better way to organize this, but let's wait until I can split Topology into multiple files. |
Then we can maybe think of merging but open an issue right away to remember that we need a better solution for this snippet of code that moved from |
Yeah, a good real arithmetic package, even without the topology/measure theory stuff, is quite useful. We should at least put an issue to be settled before next release. I'm skeptical about why Rstruct depends on normedType at all. |
We should maybe clear that up before merging. |
Ok, it was just a proof of one rather trivial lemma that we're not using anywhere. I rewrote the proof to avoid dependency on normedType, and things all work now. Assuming this builds, I think we're in good shape to merge. |
@affeldt-aist Well, some of the builds are broken, but they are a curl timeout. I'm probably not responsible for that, so we should be able to merge this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This introduces a dependency with Rstruct.v
in normedtype.v
but it is a very localized use so I think that this is reasonable.
Section normalP. | ||
Context {T : topologicalType}. | ||
|
||
Let normal_spaceP : [<-> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why a local lemma rather than a global one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just following the pattern of the other TFAE proofs like cvgryPnum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right! Indeed there is probably no legitimate use of the 1 <-> 2
correspondance, we can leave it as such (maybe we can add a doc as a justfication)
Indeed, the last CI run is as green as it can be. |
* equivalences of normal * fixing tietze and pseudometrics are normal * normal_spaceP w.o. R : realType paramater --------- Co-authored-by: Reynald Affeldt <[email protected]>
* equivalences of normal * fixing tietze and pseudometrics are normal * normal_spaceP w.o. R : realType paramater --------- Co-authored-by: Reynald Affeldt <[email protected]>
Motivation for this change
Finishing track A of #965, this makes Tietze's theorem applicable to
R
. We do 4 small things:tfae
. Here we incorporate the the traditional "separable by open sets" notion of normality.normal_space X
instead of explicitly ask thatX
has separators.Finally, this will let us turn lusin's continuous partial functions into genuine bounded,
R->R
continuous functions. This fully unblocks track B.One weird thing comes up, where the proof for
normal_spaceP
goes through the real numbers, but they don't show up in the lemma statement. This is an opportunity to use a particular instance ofrealType
to get the useless{R : realType}
out of the signature. Where is there a concrete instance ofrealType
in the mathcomp analysis?Things done/to do
CHANGELOG_UNRELEASED.md
Compatibility with MathComp 2.0
TODO: HB port
to make sure someone ports this PR tothe
hierarchy-builder
branch or I already opened an issue or PR (please cross reference).Automatic note to reviewers
Read this Checklist and put a milestone if possible.