Map decryption errors correctly from rust #3710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillCarsonFr
changed the base branch from
develop
to
valere/element-r/backup/restore/pr2
BillCarsonFr
changed the title
This was referenced Sep 7, 2023
…t-r/backup/restore/pr3
Base automatically changed from
valere/element-r/backup/restore/pr2
to
develop
September 13, 2023 09:22
andybalaam
requested changes
Sep 13, 2023
There was a problem hiding this comment.
All looks good, thanks.
For test coverage, I think a different userId seems worth testing, hopefully this.stopped is easy to test? An event without a roomId seems worth checking too. So maybe that would get us over the threshold?
I have removed the part that was mapping the rust |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
decryptEvent(event: MatrixEvent): Promise<EventDecryptionResult>Promise can be rejected withDecryptionError. This is implicilty part of API as it's used in react sdk (DecryptionFailureTracker for posthog), and it's also needed to query keybackup automatically (done in a follow-up PR).This PR uses a new functionnality in wasm binding that returns typed error for decryption failures. These error are mapped to the existing DecryptionErrors.
It's not a 1:1 mapping (can we ignore the quality gate because only 75%?)as the crypto backends do not report the same errors, but it maps the important ones.
Based on #3709
Checklist
This change is marked as an internal change (Task), so will not be included in the changelog.