-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ODK in GitHub action #100
ODK in GitHub action #100
Conversation
Remove `CL:17543` axioms
a4ec92f
to
9461feb
Compare
86ec253
to
2d8c838
Compare
b43dfdc
to
fdc3abf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matentzn This is ready for your review now. I was able to successfully run it just now.
make install | ||
- name: Create .env file | ||
run: | | ||
echo -en "API_KEY=${{ secrets.API_KEY }}" > .env | ||
echo "API_KEY=${{ secrets.API_KEY }}" > .env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bugfix. For some reason echo -en
wasn't working for me after switching over to the ODK container.
- Update: GH action workflow: (i) now uses ODK container, (ii) Had to change 'echo -en' to plain 'echo' due to some new incompatibility with new ODK environment, (iii) removed some comments; streamlined. - Update: Minor updates in a few files; code comments, codestyle, verbosity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Overview
Setting up ODK for GitHub actions so that we can run in a good environment with all dependencies, e.g.
robot
.Updates
ODK-based GitHub Action
- Update: GH action workflow: (i) now uses ODK container, (ii) Had to change 'echo -en' to plain 'echo' due to some new incompatibility with new ODK environment, (iii) removed some comments; streamlined.
- Update: Minor updates in a few files; code comments, codestyle, verbosity
Depends on
pip
not found (in GitHub Action) (edit: user error) INCATools/ontology-development-kit#888Related issues
omim.sssom.tsv
to GH action #92