Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ODK in GitHub action #100

Merged
merged 2 commits into from
Jun 21, 2023
Merged

ODK in GitHub action #100

merged 2 commits into from
Jun 21, 2023

Conversation

joeflack4
Copy link
Contributor

@joeflack4 joeflack4 commented Jun 19, 2023

Overview

Setting up ODK for GitHub actions so that we can run in a good environment with all dependencies, e.g. robot.

Updates

ODK-based GitHub Action
- Update: GH action workflow: (i) now uses ODK container, (ii) Had to change 'echo -en' to plain 'echo' due to some new incompatibility with new ODK environment, (iii) removed some comments; streamlined.
- Update: Minor updates in a few files; code comments, codestyle, verbosity

Depends on

Related issues

@joeflack4 joeflack4 self-assigned this Jun 19, 2023
@joeflack4 joeflack4 added the enhancement New feature or request label Jun 19, 2023
@joeflack4 joeflack4 linked an issue Jun 19, 2023 that may be closed by this pull request
.github/workflows/buid_and_release.yml Outdated Show resolved Hide resolved
.github/workflows/buid_and_release.yml Outdated Show resolved Hide resolved
.github/workflows/buid_and_release.yml Outdated Show resolved Hide resolved
.github/workflows/buid_and_release.yml Outdated Show resolved Hide resolved
@joeflack4 joeflack4 force-pushed the odk branch 10 times, most recently from 86ec253 to 2d8c838 Compare June 21, 2023 00:27
@joeflack4 joeflack4 force-pushed the odk branch 2 times, most recently from b43dfdc to fdc3abf Compare June 21, 2023 00:32
@joeflack4 joeflack4 marked this pull request as ready for review June 21, 2023 00:53
Copy link
Contributor Author

@joeflack4 joeflack4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matentzn This is ready for your review now. I was able to successfully run it just now.

make install
- name: Create .env file
run: |
echo -en "API_KEY=${{ secrets.API_KEY }}" > .env
echo "API_KEY=${{ secrets.API_KEY }}" > .env
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bugfix. For some reason echo -en wasn't working for me after switching over to the ODK container.

.github/workflows/buid_and_release.yml Show resolved Hide resolved
.github/workflows/buid_and_release.yml Show resolved Hide resolved
- Update: GH action workflow: (i) now uses ODK container, (ii) Had to change 'echo -en' to plain 'echo' due to some new incompatibility with new ODK environment, (iii) removed some comments; streamlined.
- Update: Minor updates in a few files; code comments, codestyle, verbosity
Copy link
Member

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joeflack4 joeflack4 merged commit 30bbfed into main Jun 21, 2023
@joeflack4 joeflack4 deleted the odk branch June 21, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GH Action: Run in ODK
2 participants