Support React 16.9

[TheRusskiy]

Add UNSAFE_ to lifecycle methods, otherwise, React 16.9 raises a warning

[nielskloster]

+1 👍

[sam3k]

Are there any plans to merge this PR?

[ryanrabello]

Tangentially related. moroshko/react-autowhatever#51 (PR for updating the react-autowhatever dependency.

[bjensen]

+1

[turadg]

When will a release be cut with this?

[moroshko]

npm i && npm t is failing on master.
Does anyone have time to look into this?

[a-x-]

I removed "babel-plugin-transform-react-remove-prop-types"

and build gonna ok

[wkerswell-gresham]

If the tests are not passing can we merge this please.

[annieredmond1]

@moroshko I just wanted to follow up and see if a release could be cut with these changes - thanks!

[lesniakania]

when can we expect release with this fix?

[bbarnell]

@moroshko We only have about 10 more months before ComponentWillReceiveProps is removed from React version 17. I hope the CDN can be updated before then.

[fatso83]

After #672 was posted @aberezkin has stepped up to start maintaining, and so this PR was finally merged today. Still, this project could use some additional steward(esse)s, so reach out if you want to help maintain this, ref. the call for maintainers on the README

[obryckim]

Thank you for this. When can we expect an updated npm package to be available?

[aberezkin]

@obryckim, I'm planning to release a new major version in a week or two after I update all dependencies and build scripts.

[dfenske]

Please post here when you merge - I am dealing with this issue too and it's flooding my test output :(

[fatso83]

@dfenske If you just need to silence the output, fork the repo and publish a private fork to NPM @dfenske/react-autosuggest with the patch. Then you get the fix today and can wait around until you need something in a future version of this package. No need to let this be show-stopper.

edit: You don't even need to publish an NPM package. NPM can use Github directly, so just point it to dfenske/react-auto-suggest after forking. Youj might need to build some distributable and commit it, but that's it.

[SimenB]

Or use patch-package

[fatso83]

Whaaat, that's amaaaazing. Not at all surprised to see you here, as well, @SimenB 😄

[adi518]

Seems fixed, but never released. Who can take care of this?

[fatso83]

@ademidun That is incorrect. This was merged in first half of 2020. There has been many releases published since then, last time in January 2021. https://www.npmjs.com/package/react-autosuggest?activeTab=versions

Who can take care of this?

Also answered by reading this thread.

[adi518]

Well, it's confusing since I use react-command-palette, which depends on the latest version of this package and I get this exact error.

[asabaylus]

@adi518 react-command-palette is on react-autosuggest v10.0.1. I've been unable to reproduce your error, we can continue to troubleshoot you issue outside this repo

[adi518]

@ademidun That is incorrect. This was merged in first half of 2020. There has been many releases published since then, last time in January 2021. https://www.npmjs.com/package/react-autosuggest?activeTab=versions

Who can take care of this?

Also answered by reading this thread.

GitHub collapses the last three releases (probably because they have a short description or none) so I missed it.

[adi518]

@adi518 react-command-palette is on react-autosuggest v10.0.1. I've been unable to reproduce your error, we can continue to troubleshoot you issue outside this repo

I'm getting this warning in strict mode, so unfortunately, this issue and the PR that fixed it are irrelevant. This is the relevant issue: #624. I'm using React 17 in strict mode.

[duhaime]

This PR doesn't add support for React 16.9. This change now throws another warning:

index.js:1 Warning: Unsafe lifecycle methods were found within a strict-mode tree:
    in StrictMode (at src/index.js:8)

componentWillReceiveProps: Please update the following components to use static getDerivedStateFromProps instead: Autosuggest, Autowhatever

Learn more about this warning here:
https://fb.me/react-strict-mode-warnings