Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/delete old code #330

Merged
merged 4 commits into from
Aug 12, 2024
Merged

Feature/delete old code #330

merged 4 commits into from
Aug 12, 2024

Conversation

rjgriffin42
Copy link
Member

No description provided.

@rjgriffin42 rjgriffin42 force-pushed the feature/delete_old_code branch from 5d98cc6 to 6648620 Compare August 7, 2024 22:05
@rjgriffin42 rjgriffin42 requested a review from calvertdw August 8, 2024 04:43
@rjgriffin42 rjgriffin42 force-pushed the feature/delete_old_code branch from f98b029 to 399db08 Compare August 8, 2024 21:12
Copy link
Collaborator

@stephenmcc stephenmcc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, the one thing I'd request is squashing into a single commit.

@rjgriffin42 rjgriffin42 force-pushed the feature/delete_old_code branch 2 times, most recently from 101aa24 to 734269c Compare August 12, 2024 20:43
@rjgriffin42
Copy link
Member Author

All looks good, the one thing I'd request is squashing into a single commit.

@stephenmcc went through and squashed down into four commits for the three different things (delete code, fix tests, clean dependencies)

Copy link
Member

@calvertdw calvertdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to keep DurationStatisticPrinter, but other changes look good.

…rajectory and its implementations. Hexapod still depends on it.

delete matrix yo variable converter tools

delete some old yo variable tools

delete some unused yo variable tools

delete unused stiction model tools

delete unused alpha to alpha functions

deleted some controller classes, and left others to be reviewed

deprecated some straght line tests, they need to be pushed into the striaght line pose traejctory

removed straight line poisition trajectory from the pose test

removed the straight line independent trajectory generators that werent used

deleted the unused qp code

deleted projection tools

started switching away from random geometry class and the old robotics assert

converted more of the tests to the right format

switched getting all the current crop of moving away from random geometry working

got rid of the custom random matrix generator class

deleted the random geometry class, since its duplicated by other tools

fixed some deletes and removed some provider structure that did nothing

fixed some more deletes

moved the planar landmark to the correct place

deleted many other classes

delete unused code

deleted a whole bunch of stuff from the java toolkit

deleted the simple walking controller
fixed the test to do max absolute value instead of the one done by ddefault
did more dependency cleanup

finished cleaning up the source dependencies

went through all the jar dependencies
@rjgriffin42 rjgriffin42 force-pushed the feature/delete_old_code branch from 734269c to 328b819 Compare August 12, 2024 22:31
@rjgriffin42 rjgriffin42 merged commit a10249a into develop Aug 12, 2024
19 of 35 checks passed
@rjgriffin42 rjgriffin42 deleted the feature/delete_old_code branch August 12, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants